The desire of the nations
Whether the Hebrew names a treasure of the nations or the one desired by them, and what the coming glory is.
Haggai 2:6-9
6For this is what Yahweh of Armies says: ‘Yet once, it is a little while, and I will shake the heavens, the earth, the sea, and the dry land;
7and I will shake all nations. The precious things of all nations will come, and I will fill this house with glory, says Yahweh of Armies.
8The silver is mine, and the gold is mine,’ says Yahweh of Armies.
9‘The latter glory of this house will be greater than the former,’ says Yahweh of Armies; ‘and in this place I will give peace,’ says Yahweh of Armies.”
What each tradition says
Rabbinic / Midrashic
Emil G. Hirsch notes that Haggai 2:8 has been taken to refer to the Messiah, with the name "Mohammed" compared. But he says the allusion is distinctly to the "precious possessions" of the nations; perhaps it should be vocalized "ḥamudot."
Emil G. Hirsch, Haggai, Book of (Jewish Encyclopedia, 1901-1906) — 'Variæ Lectiones' section, on Haggai 2:8 ('the desire of all nations')
Patristic
No sourced position found. Checked ANF vols. 1-7 (Justin, Irenaeus, Clement, Tertullian, Hippolytus, Cyprian, Lactantius) and NPNF 2-7 (Cyril of Jerusalem, Gregory Nazianzen) / NPNF 2-8 (Basil) for 'desire of all nations'/'desire of nations'/'Aggaeus'/Haggai 2:7: the only 'desire of nations' uses are of Gen 49:10 (Jacob's blessing) and an editor's bracket note in Lactantius (ANF 7, p. 541 n. 502); no citable patristic statement on the reading of Haggai 2:7 found.
Catholic
Haydock takes "the desired of all nations" to be the one Jacob called the expectation of nations, because he was wanting and always necessary for all. Thus the sick desire a remedy, though they do not know what it is.
George Leo Haydock, George Haydock's Catholic Bible Commentary (1859) — Note on Haggai 2:8 ('the desired of all nations')
Orthodox
No sourced position found. Searched CCEL (ANF 1-7, NPNF 2-7/2-8), archive.org and the web for an Eastern/Orthodox public-domain comment on Haggai 2:6-9 ('the desire of all nations'); only modern (in-copyright) treatments surfaced (e.g. Christian Courier, GotQuestions); Cyril of Jerusalem cites Haggai 2:4-5 for the Spirit but not 2:7's 'desire'. No citable PD Eastern statement found.
Reformed / Protestant
Calvin says the "desire of all nations" may mean Christ, in whom all wishes should center; when he is manifested, the second Temple's glory becomes illustrious. But because "Mine is the silver, and mine is the gold" follows, the simpler meaning is that nations come bringing their riches, offering themselves and all they possess as a sacrifice to God.
John Calvin, Commentaries on the Twelve Minor Prophets, vol. 4: Habakkuk, Zephaniah, Haggai (trans. John Owen; Calvin Translation Society) — Commentary on Haggai 2:7 ('The desire of all nations')
Evangelical
John Wesley takes "the desire of all nations" to mean Christ, who is most desirable to all nations. He says Christ was desired by all who knew their own misery, is sufficient to save them, and was to be the light of the Gentiles and the glory of Israel.
John Wesley, Explanatory Notes upon the Old Testament — Notes on Haggai 2:7 ('the desire of all nations')